Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
nscuro
force-pushed
the
decomm-notification-publisher
branch
4 times, most recently
from
83dbb72 to
71ebbf5
Compare
nscuro
force-pushed
the
decomm-notification-publisher
branch
4 times, most recently
from
7dea50f to
bb4e92c
Compare
nscuro
force-pushed
the
decomm-notification-publisher
branch
from
bb4e92c to
0bab13c
Compare
nscuro
force-pushed
the
decomm-notification-publisher
branch
8 times, most recently
from
feb2a73 to
19488a2
Compare
There was a problem hiding this comment.
Pull request overview
This PR decommissions the standalone notification-publisher module, with notification functionality now integrated into the API server (as indicated by the dependency on hyades-apiserver#1624). The change represents a significant architectural shift from a separate microservice to an integrated approach.
Changes:
- Removed the entire
notification-publishermodule including source code, tests, and Docker configurations - Removed notification-specific Kafka topics and related infrastructure
- Cleaned up persistence models, repositories, and utilities that were only used by the notification publisher
- Updated E2E tests to use the new notification API endpoints in the API server
- Added new documentation structure for notifications under
docs/usage/notifications/
Reviewed changes
Copilot reviewed 107 out of 113 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Removed notification-publisher module and unused dependencies (pebble, parallel-consumer, quarkus-mailpit) |
| scripts/create-topics.sh | Removed creation of notification-specific Kafka topics |
| docker-compose.yml | Removed notification-publisher service container |
| monitoring/prometheus.yml | Removed prometheus scrape config for notification-publisher |
| e2e/**/*.java | Updated E2E tests to use new notification API endpoints and configuration approach |
| commons/** | Removed unused utility methods no longer needed without notification publisher |
| commons-persistence/** | Removed notification-specific models, repositories, and converters |
| docs/** | Added new notification documentation structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nscuro
force-pushed
the
decomm-notification-publisher
branch
from
19488a2 to
94812c6
Compare
nscuro
force-pushed
the
decomm-notification-publisher
branch
from
94812c6 to
db11dc6
Compare
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
force-pushed
the
decomm-notification-publisher
branch
from
db11dc6 to
7bb276d
Compare
Description
Decommissions notification publisher.
Addressed Issue
N/A
Additional Details
API server PR: DependencyTrack/hyades-apiserver#1624
Frontend PR: DependencyTrack/hyades-frontend#386
Helm PR: DependencyTrack/helm-charts#287
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly